Skip to content

chore(repo): add tracking issue template#5515

Merged
mergify[bot] merged 9 commits intomasterfrom
somayb/tracking-issue-template
Feb 26, 2020
Merged

chore(repo): add tracking issue template#5515
mergify[bot] merged 9 commits intomasterfrom
somayb/tracking-issue-template

Conversation

@SomayaB
Copy link
Contributor

@SomayaB SomayaB commented Dec 20, 2019

Add a tracking issue template to make the new roadmap tracking issues faster to create for each module.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@SomayaB
add a module tracking issue template
16fc1ed 
Add a tracking issue template to make the new roadmap tracking issues faster to create for each module.
@SomayaB SomayaB requested review from NGL321 and ccfife December 20, 2019 23:07
@SomayaB SomayaB self-assigned this Dec 20, 2019
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 20, 2019
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Dec 20, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jan 23, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

NGL321
NGL321 reviewed Jan 24, 2020
View reviewed changes
Copy link
Contributor

@NGL321 NGL321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
I left a couple comments. Not sure if they are actionable though. I can approve this whenever the comments are addressed (adding reasoning is plenty).

nija-at
nija-at suggested changes Jan 31, 2020
View reviewed changes
@SomayaB SomayaB requested a review from nija-at January 31, 2020 23:44
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 1, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ccfife
ccfife reviewed Feb 6, 2020
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 25, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 021149e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 26, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 10a6fb2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Feb 26, 2020
nija-at
nija-at approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things below. Remove the 'do-not-merge' label once you've addressed them to your satisfaction. Thanks!

@SomayaB SomayaB removed the pr/do-not-merge This PR should not be merged at this time. label Feb 26, 2020
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 26, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1db98d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 26, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fcee445
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 26, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cff6e75
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 26, 2020

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1fabbde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9156093 into master Feb 26, 2020
@mergify mergify bot deleted the somayb/tracking-issue-template branch February 26, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@NGL321 NGL321 NGL321 left review comments

@ccfife ccfife ccfife left review comments

@nija-at nija-at nija-at approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SomayaB SomayaB

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SomayaB @aws-cdk-automation @NGL321 @nija-at @ccfife